Fix missing ROS2MedkitCompat.cmake in sensor_diagnostics Dockerfile#29
Merged
bburda merged 1 commit intoselfpatch:mainfrom Feb 19, 2026
Conversation
Preserve the shared CMake module from the ros2_medkit clone before deleting it. Without this, colcon build fails because ros2_medkit_serialization (and other packages) cannot resolve their ../../cmake/ROS2MedkitCompat.cmake include path. Fixes selfpatch#28
2 tasks
bburda
approved these changes
Feb 19, 2026
Contributor
bburda
left a comment
bburda
left a comment
There was a problem hiding this comment.
@victorsolaz Thanks for this! +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve
ROS2MedkitCompat.cmakefrom theros2_medkitclone before deleting it in the sensor_diagnostics Dockerfile. Without this,colcon buildfails becauseros2_medkit_serialization(and other packages) cannot resolve their../../cmake/ROS2MedkitCompat.cmakeinclude path.The fix adds a single line to copy the shared CMake module to
${COLCON_WS}/cmake/— the exact location the relative paths resolve to from packages under${COLCON_WS}/src/.Related Issue
Closes #28
Checklist